Skip to content

better limit name schema validation #3349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

better limit name schema validation #3349

wants to merge 2 commits into from
+16 −15

Conversation

@Mathieu-Deharbe
Copy link
Contributor

@Mathieu-Deharbe Mathieu-Deharbe commented Oct 2, 2025

  1. Adds a missing key
  2. simplify limit name validation and prevent an error when a user delete a limit and recreate one with the same name -> the deleted limit is still there and counted as a doublon of limits with the same name
  3. I removed some checks which are obsolete

I am not sure that this is a right thing to put all those field to UNDEFINED in the limit types. -> should be checked

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 2, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Mathieu-Deharbe